Skip to content

change ExchangeMarket properties to nullable #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vslee merged 1 commit into from
Feb 6, 2022
Merged

change ExchangeMarket properties to nullable #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ protected internal override async Task<IEnumerable<ExchangeMarket>> OnGetMarketS

protected override async Task<IEnumerable<string>> OnGetMarketSymbolsAsync()
{
return (await GetMarketSymbolsMetadataAsync()).Where(market => market.IsActive).Select(market => market.MarketSymbol);
return (await GetMarketSymbolsMetadataAsync()).Where(market => market.IsActive ?? true).Select(market => market.MarketSymbol);
}

protected override async Task<IReadOnlyDictionary<string, ExchangeCurrency>> OnGetCurrenciesAsync()
Expand Down
8 changes: 6 additions & 2 deletions src/ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ protected virtual Task<IWebSocket> OnUserDataWebSocketAsync(Action<object> callb
protected async Task<decimal> ClampOrderPrice(string marketSymbol, decimal outputPrice)
{
ExchangeMarket? market = await GetExchangeMarketFromCacheAsync(marketSymbol);
return market == null ? outputPrice : CryptoUtility.ClampDecimal(market.MinPrice, market.MaxPrice, market.PriceStepSize, outputPrice);
if (market.MinPrice == null || market.MaxPrice == null || market.PriceStepSize == null)
throw new NotImplementedException($"Exchange must return {nameof(market.MinPrice)} and {nameof(market.MaxPrice)} in order for {nameof(ClampOrderPrice)}() to work");
else return market == null ? outputPrice : CryptoUtility.ClampDecimal(market.MinPrice.Value, market.MaxPrice.Value, market.PriceStepSize, outputPrice);
}

/// <summary>
Expand All @@ -257,7 +259,9 @@ protected async Task<decimal> ClampOrderPrice(string marketSymbol, decimal outpu
protected async Task<decimal> ClampOrderQuantity(string marketSymbol, decimal outputQuantity)
{
ExchangeMarket? market = await GetExchangeMarketFromCacheAsync(marketSymbol);
return market == null ? outputQuantity : CryptoUtility.ClampDecimal(market.MinTradeSize, market.MaxTradeSize, market.QuantityStepSize, outputQuantity);
if (market.MinPrice == null || market.MaxPrice == null || market.PriceStepSize == null)
throw new NotImplementedException($"Exchange must return {nameof(market.MinPrice)} and {nameof(market.MaxPrice)} in order for {nameof(ClampOrderQuantity)}() to work");
else return market == null ? outputQuantity : CryptoUtility.ClampDecimal(market.MinTradeSize.Value, market.MaxTradeSize.Value, market.QuantityStepSize, outputQuantity);
}

/// <summary>
Expand Down
12 changes: 6 additions & 6 deletions src/ExchangeSharp/Model/ExchangeMarket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class ExchangeMarket
public string AltMarketSymbol2 { get; set; }

/// <summary>A value indicating whether the market is active.</summary>
public bool IsActive { get; set; }
public bool? IsActive { get; set; }

/// <summary>In a pair like ZRX/BTC, BTC is the quote currency.</summary>
public string QuoteCurrency { get; set; }
Expand All @@ -38,10 +38,10 @@ public class ExchangeMarket

/// <summary>The minimum size of the trade in the unit of "BaseCurrency". For example, in
/// DOGE/BTC the MinTradeSize is currently 423.72881356 DOGE</summary>
public decimal MinTradeSize { get; set; }
public decimal? MinTradeSize { get; set; }

/// <summary>The maximum size of the trade in the unit of "BaseCurrency".</summary>
public decimal MaxTradeSize { get; set; } = decimal.MaxValue;
public decimal? MaxTradeSize { get; set; }

/// <summary>The minimum size of the trade in the unit of "QuoteCurrency". To determine an order's
/// trade size in terms of the Quote Currency, you need to calculate: price * quantity
Expand All @@ -54,10 +54,10 @@ public class ExchangeMarket
public decimal? MaxTradeSizeInQuoteCurrency { get; set; }

/// <summary>The minimum price of the pair.</summary>
public decimal MinPrice { get; set; }
public decimal? MinPrice { get; set; }

/// <summary>The maximum price of the pair.</summary>
public decimal MaxPrice { get; set; } = decimal.MaxValue;
public decimal? MaxPrice { get; set; }

/// <summary>Defines the intervals that a price can be increased/decreased by. The following
/// must be true for price: Price % PriceStepSize == 0 Null if unknown or not applicable.</summary>
Expand All @@ -71,7 +71,7 @@ public class ExchangeMarket
/// <summary>
/// Margin trading enabled for this market
/// </summary>
public bool MarginEnabled { get; set; }
public bool? MarginEnabled { get; set; }

public override string ToString()
{
Expand Down