Added ability to GetOrderDetailsAsync() by ClientOrderId#647
Merged
vslee merged 2 commits intoDigitalRuby:masterfrom Sep 18, 2021
Merged
Added ability to GetOrderDetailsAsync() by ClientOrderId#647vslee merged 2 commits intoDigitalRuby:masterfrom
vslee merged 2 commits intoDigitalRuby:masterfrom
Conversation
Collaborator
vslee
commented
Sep 16, 2021
- many, but not all, exchanges support this
- many, but not all, exchanges support this
jjxtra
requested changes
Sep 18, 2021
Collaborator
jjxtra
left a comment
There was a problem hiding this comment.
Thanks for the pr. I request that you move this new optional parameter to the end of the method so that we don't break everyone who updates to this new version.
Collaborator
Author
|
Done |
jjxtra
approved these changes
Sep 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.