This repository was archived by the owner on Mar 13, 2024. It is now read-only.
Code Review#79
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 16 16
=========================================
Hits 16 16 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coretl
reviewed
Nov 9, 2022
d5d59c3 to
c2db66d
Compare
coretl
reviewed
Nov 9, 2022
coretl
reviewed
Nov 9, 2022
Contributor
Author
|
I changed back to using head (but kept your modified comment) This is because $(ls src) meant that the --version was not getting passed (maybe because it ended up with a trailing line break?) |
Contributor
Author
|
I think this is ready to merge. |
coretl
reviewed
Nov 9, 2022
coretl
reviewed
Nov 9, 2022
Closed
garryod
reviewed
Nov 9, 2022
039c4a0 to
69835dd
Compare
GDYendell
reviewed
Nov 10, 2022
c1a0b2d to
2b640e3
Compare
coretl
reviewed
Nov 10, 2022
5e9df62 to
541f176
Compare
coretl
reviewed
Nov 10, 2022
b164ee6 to
187a4b2
Compare
coretl
reviewed
Nov 10, 2022
2a0632f to
d0a8b23
Compare
Contributor
Author
|
@coretl ready to merge (again!) I've verified that release works (you missed 'do' out of your bash for loop) |
52506ee to
09b0ac7
Compare
- Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of changes as proposed in #75