Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Changed the order so that when 'new' is ran the package name is validated before mkdir#78

Merged
coretl merged 1 commit into
mainfrom
new_directory_is_created_even_if_package_name_is_invalid
Mar 17, 2023
Merged

Changed the order so that when 'new' is ran the package name is validated before mkdir#78
coretl merged 1 commit into
mainfrom
new_directory_is_created_even_if_package_name_is_invalid

Conversation

@evvaaaa
Copy link
Copy Markdown
Contributor

@evvaaaa evvaaaa commented Mar 17, 2023

Closes #64

@evvaaaa evvaaaa changed the title Changed the order so that when 'new' is ran the package name is valid……ated before mkdir Changed the order so that when 'new' is ran the package name is validated before mkdir Mar 17, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2023

Codecov Report

Merging #78 (9e03794) into main (63677e7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          138       138           
=========================================
  Hits           138       138           
Impacted Files Coverage Δ
src/python3_pip_skeleton/__main__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Collaborator

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Worth writing a test for it?

@coretl coretl merged commit c784df0 into main Mar 17, 2023
@coretl coretl deleted the new_directory_is_created_even_if_package_name_is_invalid branch March 17, 2023 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New directory is created even if package name is invalid

3 participants