This repository was archived by the owner on Mar 13, 2024. It is now read-only.
Changed the ignore functionality so individual lines in files can be ignored#77
Merged
evvaaaa merged 6 commits intoApr 17, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 199 223 +24
=========================================
+ Hits 199 223 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
303dd18 to
b446bd5
Compare
b446bd5 to
12179a8
Compare
coretl
reviewed
Mar 20, 2023
78b848d to
7d0828c
Compare
7d0828c to
14a16cb
Compare
coretl
reviewed
Apr 13, 2023
3310e9d to
c90478e
Compare
GDYendell
reviewed
Apr 14, 2023
628e714 to
c256058
Compare
… we'll later change back
c256058 to
de784b4
Compare
coretl
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #75
IGNORE_FILES is now a dictionary, where keys are string names of files to be ignored, and values are of type
List[int]. If the value is an empty list then the file will be ignored completely and not replaced. If the value containsints then those lines will be ignored in that file, and the rest of the file will run through the same replacement as before. int line numbers start at 1 and not 0 (the first line in a file is 1).Tested with an
exisitingrun where the specified line in the README (from issue #75) was correctly ignored with the rest of the file swapped.