Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

test_adopt.py: test_new_module fails locally#69

Merged
gilesknap merged 1 commit into
mainfrom
68_test_new_module_fails_locally
Feb 2, 2023
Merged

test_adopt.py: test_new_module fails locally#69
gilesknap merged 1 commit into
mainfrom
68_test_new_module_fails_locally

Conversation

@evvaaaa
Copy link
Copy Markdown
Contributor

@evvaaaa evvaaaa commented Feb 2, 2023

Closes #68

In the test, the version of sphinx used is incompatible with sphinx_design when ran locally.

Ensuring an upgrade to pip inside the test generated pip environment fixes this. The github runner uses an up to date version already which is why it passes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2023

Codecov Report

Merging #69 (ccf56ce) into main (acb8293) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          135       135           
=========================================
  Hits           135       135           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evvaaaa evvaaaa requested a review from coretl February 2, 2023 11:33
@evvaaaa evvaaaa self-assigned this Feb 2, 2023
@evvaaaa evvaaaa force-pushed the 68_test_new_module_fails_locally branch from ccf56ce to 10e659c Compare February 2, 2023 11:38
Copy link
Copy Markdown
Contributor

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilesknap gilesknap merged commit 282fc92 into main Feb 2, 2023
@evvaaaa evvaaaa deleted the 68_test_new_module_fails_locally branch February 3, 2023 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_adopt.py: test_new_module fails locally

2 participants