Skip to content

Register FIB data in ISPyB#805

Open
tieneupin wants to merge 10 commits into
mainfrom
register-fib-ispyb-data
Open

Register FIB data in ISPyB#805
tieneupin wants to merge 10 commits into
mainfrom
register-fib-ispyb-data

Conversation

@tieneupin
Copy link
Copy Markdown
Contributor

@tieneupin tieneupin commented May 20, 2026

Extends the existing FIB data registration workflow to insert a DataCollectionGroup and Atlas into ISPyB for each unique sample detected.

Currently inserts the path to the real image, as thumbnail generation logic hasn't been implemented yet.

@tieneupin tieneupin force-pushed the register-fib-ispyb-data branch 2 times, most recently from 7c7f895 to c747bfb Compare May 21, 2026 09:48
Comment thread tests/workflows/fib/test_register_atlas.py Fixed
@tieneupin tieneupin force-pushed the register-fib-ispyb-data branch from c747bfb to 67bf24f Compare May 21, 2026 10:01
tieneupin added 2 commits May 21, 2026 11:35
…t the end of the function, and both new and old entries are populated or updated correctly
@tieneupin tieneupin force-pushed the register-fib-ispyb-data branch from 67bf24f to 409f9a4 Compare May 21, 2026 10:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 79.10448% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.22%. Comparing base (408efc8) to head (89f34b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   52.12%   52.22%   +0.09%     
==========================================
  Files          96       97       +1     
  Lines       10402    10448      +46     
  Branches     1377     1384       +7     
==========================================
+ Hits         5422     5456      +34     
- Misses       4696     4704       +8     
- Partials      284      288       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin force-pushed the register-fib-ispyb-data branch from 949aa3c to df5c51a Compare May 21, 2026 16:55
@tieneupin tieneupin force-pushed the register-fib-ispyb-data branch from df5c51a to 06d9cac Compare May 21, 2026 17:00
@tieneupin tieneupin marked this pull request as ready for review May 21, 2026 17:04
@tieneupin tieneupin self-assigned this May 21, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component fib Part of the FIB pipeline extension labels May 21, 2026
)

# Mock the metadata returned from the image file
import murfey.workflows.fib.register_atlas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants