Check directory file numbers when returning configuration#51
Merged
Conversation
Collaborator
Author
|
bc808c5 to
4f553f6
Compare
If the two numbers do not match, it is useful to see both in the configuration to help debugging issues, especially around interactions with the GDA files.
Now that it is wrapped in a CurrentConfiguration there is no conflict with the graphql version of the function.
4f553f6 to
6d8846b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #50
I'm not convinced this doesn't just move the confusion elsewhere. It doesn't give the same
get configuration latestScanNumber -> 0followed byget next scan number -> 42behaviour but does meanget configurationdoesn't return the same configuration you've just set viaset configuration.Maybe
get configurationwould be better off returning a different type with db_number and dir_number as different fields?