Bundle root certificates at compile time#39
Merged
Merged
Conversation
In order to make https connections for authorisation, the reqwuest library needs root certificates. In the minimal container used, these are not present in the OS so authorisation fails. By bundling them at compile time (via the webpki-roots crate) the native certificates are not required. This usually presents a maintenance burden as the application needs to be recompiled if root CA certificates change, however in the case where the application is running in a container, the container would need to be rebuilt in either case to include the new certificates.
|
Seems reasonable to me - it's what I do for most of my services. My only suggestion would be setting up |
Collaborator
Author
|
Thanks, I'll look into setting up dependabot in a separate change.
Tricky but doable/copyable? |
Looks like you can set the dependabot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make https connections for authorisation, the reqwuest
library needs root certificates. In the minimal container used, these
are not present in the OS so authorisation fails. By bundling them at
compile time (via the webpki-roots crate) the native certificates are
not required.
This usually presents a maintenance burden as the application needs to
be recompiled if root CA certificates change, however in the case where
the application is running in a container, the container would need to
be rebuilt in either case to include the new certificates.