Return status information from status endpoint#33
Merged
Conversation
b1ca67c to
b8e7554
Compare
The status endpoint is currently only used as a liveness probe for kubernetes deployments but returning a version and start time provides a useful sanity check of the running version without having to use the kubernetes dashboard. The dockerfile needs to be updated to include the build.rs file and set the workdir. Previously, cargo was running in the root directory and would complain about infinite file system loops in /proc/.
b8e7554 to
eb3807d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status endpoint is currently only used as a liveness probe for
kubernetes deployments but returning a version and start time provides a
useful sanity check of the running version without having to use the
kubernetes dashboard.