Conversation
e17909d to
6673f21
Compare
callumforrester
previously approved these changes
Dec 9, 2024
callumforrester
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me, it would be good if we could add tests and/or prescribe a way to test it offline
Contributor
Collaborator
Author
tpoliaw
commented
Dec 10, 2024
callumforrester
previously approved these changes
Dec 13, 2024
callumforrester
left a comment
Contributor
There was a problem hiding this comment.
I'm happy I understand these changes although my understanding of OPA et al. is still limited
Allows the host to be configurable via CLI/env
As the central admin rules do not provide a convenient single endpoint, we're now using the 'ad-hoc query' endpoint and taking the required queries as user provided configuration.
Requires new rules on central OPA instance but allows all logic to be reduced to a single yes/no response.
Now there are no return types to handle there is no need to separate the admin and access versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.