Template 404 page to account for public_address#98
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 49.27% 48.80% -0.48%
==========================================
Files 13 13
Lines 621 627 +6
==========================================
Hits 306 306
- Misses 315 321 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de566a5 to
b37a7af
Compare
|
I have checked that it does not working for localhost case as it tries to redirect me to "127.0.0.1/" (which does mean localhost) You can try this by doing You can also check at https://p46-blueapi.diamond.ac.uk/glazed/ |
|
The problem is that by default it binds to Potential fixes
Oddly, if I try to run with this PR but no config, clicking the link gives me an error |
I don't think the p46 version has this change (or if it does, the public address needs a trailing |
|
We need the |
If the service is not hosted at the root of a domain, the links to the graphql and graphiql endpoints cannot be absolute.
Bit of an overkill for two urls
If the service is not hosted at the root of a domain, the links to the
graphql and graphiql endpoints cannot be absolute.