Add search for root and run containers#31
Conversation
tpoliaw
left a comment
There was a problem hiding this comment.
The change itself looks fine, but it is just mirroring the API tiled gives us and I don't really understand the structure of the JSON it sends. At some point it would be good to look at the use cases we're actually going to need and cater for them in a way that doesn't rely on the user knowing about the tiled API.
For now it is probably ok to expose everything and figure out which bits are useful when they're being used.
|
That was exactly my thought process with this (and the next few) PR's. I thought it more useful to expose everything and then have a play with it and focus in on what we want than trying to figure it out without implementing it. Also, at which point, we can refactor it in a way that makes more sense once we are better informed. |
7d453be to
7371714
Compare
|
Closing this pr as it is now three smaller prs. |
No description provided.