Skip to content

Add search for root and run containers#31

Closed
abbiemery wants to merge 28 commits into
mainfrom
add-search
Closed

Add search for root and run containers#31
abbiemery wants to merge 28 commits into
mainfrom
add-search

Conversation

@abbiemery

Copy link
Copy Markdown
Contributor

No description provided.

@abbiemery abbiemery requested a review from tpoliaw November 10, 2025 12:04

@tpoliaw tpoliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine, but it is just mirroring the API tiled gives us and I don't really understand the structure of the JSON it sends. At some point it would be good to look at the use cases we're actually going to need and cater for them in a way that doesn't rely on the user knowing about the tiled API.

For now it is probably ok to expose everything and figure out which bits are useful when they're being used.

Comment thread src/model/event_stream.rs Outdated
Comment thread src/model/node.rs Outdated
@abbiemery

abbiemery commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

That was exactly my thought process with this (and the next few) PR's. I thought it more useful to expose everything and then have a play with it and focus in on what we want than trying to figure it out without implementing it.

Also, at which point, we can refactor it in a way that makes more sense once we are better informed.

@abbiemery abbiemery marked this pull request as ready for review November 10, 2025 17:27
@abbiemery

Copy link
Copy Markdown
Contributor Author

@abbiemery abbiemery closed this Nov 10, 2025
@abbiemery abbiemery self-assigned this Nov 10, 2025
@abbiemery abbiemery deleted the add-search branch November 10, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants