Hinted attribute validation#268
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 89.33% 89.35% +0.01%
==========================================
Files 45 45
Lines 2269 2273 +4
==========================================
+ Hits 2027 2031 +4
Misses 242 242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
284b2e5 to
41049a1
Compare
jsouter
reviewed
Nov 14, 2025
jsouter
reviewed
Nov 14, 2025
Check datatype and access mode in add_attribute, check for unintrospected type hints after initialise
41049a1 to
c02a3e1
Compare
c02a3e1 to
29c990a
Compare
jsouter
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Attributenow raises aRuntimeError, even if the type and access mode match. To statically type hint anAttributeto be introspected during initialisation, only specify the type hint on the class - do not create a default instance, e.g.attr: AttrRW[int], notattr = AttrRW(Int()).Controller.attributesis now a read-only view. UseController.add_attributeto create Attributes, which will perform validation.Sorry the diff is a bit horrible because I moved methods around, but I think it has made it easier to read through the code.