Skip to content

Add devices for VMXM ispyb gridscan info#1925

Merged
rtuck99 merged 10 commits into
mainfrom
add_vmxm_devices_for_ispyb_integration
May 13, 2026
Merged

Add devices for VMXM ispyb gridscan info#1925
rtuck99 merged 10 commits into
mainfrom
add_vmxm_devices_for_ispyb_integration

Conversation

@olliesilvester
Copy link
Copy Markdown
Contributor

@olliesilvester olliesilvester commented Feb 17, 2026

These devices are used for ispyb metadata when doing grid scans.

Currently this doesn't connect because the prefix on vmxm's flux PV is different to that of the common device.

Instructions to reviewer on how to test:

  1. check dodal connect i02_1 on this branch

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@olliesilvester olliesilvester requested a review from a team as a code owner February 17, 2026 17:02
@olliesilvester olliesilvester marked this pull request as draft February 17, 2026 17:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (dd687cc) to head (c64c3e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         331      331           
  Lines       12886    12913   +27     
=======================================
+ Hits        12773    12800   +27     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester olliesilvester marked this pull request as ready for review February 18, 2026 10:58
Comment thread src/dodal/beamlines/i02_1.py Outdated
Comment thread src/dodal/devices/beamlines/i02_1/sample_motors.py Outdated
@olliesilvester olliesilvester force-pushed the add_vmxm_devices_for_ispyb_integration branch from 4cc02af to fc88823 Compare March 10, 2026 10:47
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rtuck99 rtuck99 dismissed oliwenmandiamond’s stale review May 13, 2026 12:44

Changes addressed

@rtuck99 rtuck99 enabled auto-merge (squash) May 13, 2026 12:46
@rtuck99 rtuck99 merged commit dfd1705 into main May 13, 2026
8 checks passed
@rtuck99 rtuck99 deleted the add_vmxm_devices_for_ispyb_integration branch May 13, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants