Add Slits with Individual blade control. Add those devices to i22#1655
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 327 327
Lines 12812 12820 +8
=======================================
+ Hits 12699 12707 +8
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is the 2nd time we making slit blade for slits, should we think about moving it to common and standardise what it call? dodal/src/dodal/devices/i10/slits.py Line 9 in ea92977 |
|
From a quick look at current the current synoptics, it seems like is most widely in use, with some other naming conventions having a few instruments using them:
and a few with only a single instrument:
|
DominicOram
left a comment
There was a problem hiding this comment.
I'm going to get this merged as I think it's good.
This is the 2nd time we making slit blade for slits, should we think about moving it to common and standardise what it call?
From @EmsArnold comment it sounds like the de facto standard is +/- and i10 is the odd one out. It would be good if i10 could follow the same standard but I will leave you to discuss that with the scientists
This allows slits to either controlled via x_gap / y_gap nomenclature or x_plus / x_minus. Apparently necessary on i22 and requested