Skip to content

Add Slits with Individual blade control. Add those devices to i22#1655

Merged
DominicOram merged 2 commits into
mainfrom
slits_with_blades
May 11, 2026
Merged

Add Slits with Individual blade control. Add those devices to i22#1655
DominicOram merged 2 commits into
mainfrom
slits_with_blades

Conversation

@RJCD-Diamond
Copy link
Copy Markdown
Contributor

@RJCD-Diamond RJCD-Diamond commented Oct 23, 2025

This allows slits to either controlled via x_gap / y_gap nomenclature or x_plus / x_minus. Apparently necessary on i22 and requested

@RJCD-Diamond RJCD-Diamond requested a review from a team as a code owner October 23, 2025 09:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (a832c86) to head (441df05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1655   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         327      327           
  Lines       12812    12820    +8     
=======================================
+ Hits        12699    12707    +8     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could: Did you try just adding these to the Slits and running dodal connect to see what broke? I think most of the slits on my beamlines have these PVs too and I don't see any harm in adding them across the board

@Relm-Arrowny
Copy link
Copy Markdown
Contributor

Relm-Arrowny commented Oct 23, 2025

This is the 2nd time we making slit blade for slits, should we think about moving it to common and standardise what it call?

class I10SlitsBlades(Slits):

@EmsArnold
Copy link
Copy Markdown
Contributor

From a quick look at current the current synoptics, it seems like

x_minus: str = "X:MINUS", x_plus: str = "X:PLUS", y_minus: str = "Y:MINUS", y_plus: str = "Y:PLUS"

is most widely in use, with some other naming conventions having a few instruments using them:

  • inboard/outboard/bottom/top
  • ring/hall/minus/plus
  • neg/pos/neg/pos

and a few with only a single instrument:

  • 2/1/2/1
  • nearside/offside/bottom/top
  • nearside/offside/lower/upper

Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to get this merged as I think it's good.

This is the 2nd time we making slit blade for slits, should we think about moving it to common and standardise what it call?

From @EmsArnold comment it sounds like the de facto standard is +/- and i10 is the odd one out. It would be good if i10 could follow the same standard but I will leave you to discuss that with the scientists

@DominicOram DominicOram merged commit f637d5d into main May 11, 2026
19 of 20 checks passed
@DominicOram DominicOram deleted the slits_with_blades branch May 11, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants