This repository was archived by the owner on May 7, 2026. It is now read-only.
remove side effects#8
Merged
Merged
Conversation
…ng logic into routes or services where appropriate
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 86.31% 85.52% -0.80%
==========================================
Files 25 25
Lines 519 525 +6
==========================================
+ Hits 448 449 +1
- Misses 71 76 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
garryod
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed side effect functions which raise errors, instead incorporating logic into routes or services where appropriate