This repository was archived by the owner on May 7, 2026. It is now read-only.
Developing more robust persistence layer#5
Merged
Merged
Conversation
…for better readability
…ning API commands didnt finish but also did not throw errors
garryod
suggested changes
Jul 14, 2022
Contributor
garryod
left a comment
There was a problem hiding this comment.
Looks good, definitely a nice abstraction, comments are all minor
added 3 commits
July 14, 2022 14:57
…ersistence into the HklCalcStore class
…s implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merged saving/loading of Hkl pickles into one class, which inherits from generic class which can be used with any persistence method (in theory).