This repository was archived by the owner on May 7, 2026. It is now read-only.
add response models to each return type#18
Merged
Conversation
Contributor
Author
|
I'm really not sure why the code CI tests are failing... |
callumforrester
approved these changes
Aug 25, 2022
Contributor
callumforrester
left a comment
There was a problem hiding this comment.
Looks good, minor comment that you're welcome to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made new response models and ensured fastAPI was aware of each routes return type
This ensures that the openapi schema generated by fastAPI knows what return type each route has, so that any Java client generated from it will be able to incorporate this automagically.