This repository was archived by the owner on May 7, 2026. It is now read-only.
Unifying Position/PositionModel#173
Merged
Merged
Conversation
added 2 commits
January 13, 2023 14:58
…onse models file. Changed these so they rely on the existing PositionModel class, instead of creating a new Position object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that Reflection and Orientation objects return something with Position objects in them, not PositionModel. Everything else uses PositionModel. So this is to unify that functionality, and ensure any position that is returned is a PositionModel, not a Position.
got rid of core_types file and moved Orientation/Reflection into response models file. Changed these so they rely on the existing PositionModel class, instead of creating a new Position object