This repository was archived by the owner on May 7, 2026. It is now read-only.
feature: make set_lattice call accept a lattice name#17
Merged
Conversation
… the lattice. By default, if not provided, the name of the hkl object is used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added name to setLatticeParams so that a crystal name can be set with the lattice. By default, if not provided, the name of the hkl object is used instead.
Currently, the lattice name is immediately set to the same name as the hkl object. This isn't always useful or the functionality users will want. This PR attempts to resolve that.