This repository was archived by the owner on May 7, 2026. It is now read-only.
Add get routes for reflections/orientations#138
Merged
Conversation
callumforrester
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some work for conic scannables need direct retrieval of reflections/orientations in the UB Calculation object.
This PR aims to provide that functionality.
I found it easiest to create a new folder, 'types', which would store the dataclasses that my pydantic response models would use. This is because, although ideally this should be done from Irakli's code in diffcalc-core, this is difficult to do and would require extra upkeep on his part. To me it made more sense to have a structure where, no matter how Irakli serialises his objects in diffcalc-core, I can provide the same response models to any users accessing the API. This would then not affect how the objects are stored in mongo.