This repository was archived by the owner on May 7, 2026. It is now read-only.
Add more get routes#126
Merged
Merged
Conversation
Contributor
callumforrester
left a comment
There was a problem hiding this comment.
Looks good, just wondering why you've installed httpx when you already have requests
…ector/surface normal
Contributor
Author
|
Changed set_property route to:
|
callumforrester
approved these changes
Nov 25, 2022
joeshannon
reviewed
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functionality is missing which would be useful to have:
This PR addresses this, but also modifies the routes for calculating ub and getting the status of it. Now the routes look like:
GET /ub/{name}/calculate - calculates the UB
GET /ub/{name}/ub - gets the UB matrix
GET /ub/{name}/u - gets the U matrix
GET /ub/{name}/status - gets the status of the UB object, i.e. a big string.