This repository was archived by the owner on May 7, 2026. It is now read-only.
Add missing routes#111
Merged
Merged
Conversation
added 2 commits
November 10, 2022 16:32
…rectly. Also changed ub tests slightly so they do not edit the same objects, and added a fast api config in vscode
Contributor
Author
|
Also, I moved the 'calculate ub' route from the 'hkl' group to the 'ub' group as this made the most sense to me. |
keithralphs
approved these changes
Nov 11, 2022
keithralphs
left a comment
There was a problem hiding this comment.
Don't really understand the ins and out here, but the code looks reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to DAQ-4373, this PR simply adds some missing routes for adding/getting miscuts, and manually setting U/UB matrices.
Additionally, a small revision to how the TestClient was configured has been made, so that the larger number of tests pass. Previously, one object was modified by the same number of tests.