chore: making new branch#1478
Merged
Merged
Conversation
fix: Last used stamper
fix: setting to latest
fix :updating the script
fix: updating the chart
* extra comment * adding the bash script to config map, and pointing to it via the cronjob * updating release tag * was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash * updating version
* extra comment * adding the bash script to config map, and pointing to it via the cronjob * updating release tag * was calling bin/bash not bin/sh and bitnami/kubectl doesn't have full bash * updating version * changing default mode as hitting perm errors * update chart version
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## time-stamper-cron #1478 +/- ##
==================================================
Coverage 95.21% 95.21%
==================================================
Files 43 43
Lines 3132 3132
==================================================
Hits 2982 2982
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fb33899
into
DiamondLightSource:time-stamper-cron
17 of 18 checks passed
Alexj9837
added a commit
that referenced
this pull request
May 1, 2026
merging personal branch to a new branch. Add conditional cronjob and increase backoff limit Refactor time-stamper.sh script inclusion in ConfigMap Time stamper cron (#1479) Change chart version from 1.13.0 to 0.1.0 removing not fit for purpose test Update time-stamper.sh removing the logic for if the pvc wasn't mounted. now only annotates mounted pvcs. Base logic for pvc auto deletion Sorting out the weekly cronjob for pvc auto deletion, also adding someting to value yaml to turn it off Added Del perm del s changing name to be more readable fix: if there isn't a last_used check if not null Fix for time-stamper.sh as it was annotating all PVCs pvc deletion test fix removing test yaml added affinity and tolerations to cronjobs added an affinity to the cronjob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.