Skip to content

LIMS-2165: Fix Map/Model Viewer from data collection groups#1066

Merged
ndg63276 merged 1 commit into
pre-release/2026-R2.4from
fix/LIMS-2165/map-model-viewer-broken-in-groups
May 1, 2026
Merged

LIMS-2165: Fix Map/Model Viewer from data collection groups#1066
ndg63276 merged 1 commit into
pre-release/2026-R2.4from
fix/LIMS-2165/map-model-viewer-broken-in-groups

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2165

Summary:

Clicking on the "Map / Model Viewer" button from a data collection group sometimes throws an error. This was introduced by #1024

Changes:

  • Get the data collection id for each downstream processing job and return it from the backend
  • Use it to build the link to the Map / Model Viewer

To test:

  • Go to a visit with lots of groups with successful downstream processing jobs, eg /dc/visit/mx41060-23/ty/ph
  • Click the downstream processing bar on one of the blue data collection groups
  • Hover over each of the Map / Model Viewer buttons for a particular pipeline, and check each link has different data collection id's as well as autoproc ids, eg /dc/map/id/22567397/aid/119664992 and /dc/map/id/22567439/aid/119665103
  • Click each one's button, check the model loads without any errors in the dev console

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Apr 24, 2026

Seems like https://local-oidc-test.diamond.ac.uk:8082/dc/map/id/22567478/aid/119665145 returns an error, others don't, so it looks good to me, but I wanted to check that's intended

@ndg63276
Copy link
Copy Markdown
Collaborator Author

Hmmm... I don't get an error from that one... what's the message?

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Apr 27, 2026

Hmmm... I don't get an error from that one... what's the message?

When I open Uglymol, it says the file wasn't found on disk, but /dls is mounted and other electron density maps show up, so I thought maybe something got deleted or archived

@ndg63276
Copy link
Copy Markdown
Collaborator Author

How odd. It seems to load /dls/i03/data/2026/mx41060-23/processed/pipeline-final/auto/GIII/GS59_S_R23CU_NII_34/GS59_S_R23CU_NII_34_2/d7e823d4-de7f-4a61-ab9d-199f77a183bd/fast_ep/sad.pdb, which is still on disk...

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Apr 27, 2026

How odd. It seems to load /dls/i03/data/2026/mx41060-23/processed/pipeline-final/auto/GIII/GS59_S_R23CU_NII_34/GS59_S_R23CU_NII_34_2/d7e823d4-de7f-4a61-ab9d-199f77a183bd/fast_ep/sad.pdb, which is still on disk...

I think this might be something on my system then, but since everything else seems to work, I'll approve it

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.4 May 1, 2026 13:24
@ndg63276 ndg63276 merged commit b7cd1bf into pre-release/2026-R2.4 May 1, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-2165/map-model-viewer-broken-in-groups branch May 1, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants