Skip to content

LIMS-2033: Fix count of autoprocessing errors#1047

Merged
ndg63276 merged 1 commit into
pre-release/2026-R2.2from
fix/LIMS-2033/fix-count-of-autoprocessing-errors
Apr 7, 2026
Merged

LIMS-2033: Fix count of autoprocessing errors#1047
ndg63276 merged 1 commit into
pre-release/2026-R2.2from
fix/LIMS-2033/fix-count-of-autoprocessing-errors

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2033

Summary:

The autoprocessing pipelines produce messages as either INFOS, WARNINGS or ERRORS. These are displayed by the data collection or group, but the number shown is wrong.

Changes:

  • Get all the messages first, via both sets of possible joins, then Union them, then Sum them only at the end
  • Ignore autoprocprogramid so the Union command correctly ignores duplicates
  • Return totals with the dataCollectionId or dataCollectionGroupId passed in, if using a DCG then sum the totals together
  • Display the total for the group if a group is displayed
  • Dont limit the page size to 15, some jobs give more than 15 messages

To test:

  • Go to a visit with a mix of grouped and ungrouped data collections, eg /dc/visit/cm40608-5/ty/fc
  • Look for the colourful little button on each data collection like this
image - Look at an ungrouped data collection, check the numbers on the button match those displayed if you click the button (summing the tabs together) - Look at a data collection group (coloured blue), check the numbers on the button match those displayed if you click the button (summing all the tabs). These numbers may be higher as they are for all processing jobs on all DCs in the group - Click into the group, check the numbers on the buttons in the group match those displayed if you click the buttons, and add up to those shown on the whole group. (Eg group shows 87 "infos", comprising of 2 data collections with 53 and 34 "infos" respectively, see /dc/visit/cm40608-5/dcg/17176266)

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R2.2 April 7, 2026 10:14
@ndg63276 ndg63276 merged commit 0495402 into pre-release/2026-R2.2 Apr 7, 2026
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-2033/fix-count-of-autoprocessing-errors branch April 7, 2026 10:15
ndg63276 added a commit that referenced this pull request Apr 20, 2026
* LIMS-2125: Allow use of shipping service for EU dispatches (#1049)

* LIMS-2033: Fix count of autoprocessing errors (#1047)

* LIMS-2037: Remove manual check for duplicate acronyms (#1034)

* LIMS-2120: Hide courier fields if using facility account (#1050)

* LIMS-2141: Suppress errors if visit directory has been replaced with a file (#1051)

* I02-1 has 3 webcams

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants