[BUG] Python Launcher Icon - incorrect (Showing Rockstar Launcher Icon)

[ni5mo]

Please confirm these before moving forward

• I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
• I have tested that this issue has not been fixed in the latest (beta or stable) release.
• I have checked the FAQ section for solutions.
• This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version

3.3.6

Windows version, edition, and architecture

Windows 11 Pro Insider Preview - Build 26300.8068

Describe your issue

Python Launcher Icon is incorrect.
It appears to show up as Rockstar Games Launcher, I do not have this application installed - this was uninstalled about a month ago, prior to installing UniGetUI.

Also - I have checked the properties of the Phython Launcher update listed in UniGetUI and everything seems ok - its not a simple issue of two apps getting mixed up, like I said above - Rockstar Launcher isn't even installed on this machine.

See below - screenshot of incorrect icon.

Steps to reproduce the issue

No response

UniGetUI Log

n/a

Package Managers Logs

n/a

Relevant information

No response

Screenshots and videos

[br4ndol]

That’s because of the normalization of icons in the Excel sheet.
In Marti’s normalization, it stated that for Winget packages, the publisher or provider is removed and only the package name is kept. So both packages end up as “.Launcher”, and as a result, they both use the same icon.

Now that Marti is gone and it’s unclear how contributions will work, there’s no (community) method to fix this. Before Marti left, icons were managed through an Excel sheet with icon URLs and were updated every 4 days. Since then, the icons have been frozen in time until the new maintainers provide guidance on how icon contributions will work.

[mamoreau-devolutions]

I don't have an ETA yet on how the new app icons will be handled in the future, but rest assured that I've been looking at the problem and thinking about ways we could significantly increase application icon caching coverage. I have a backup copy of the original screenshot_database.xlsx file from Marti's google docs, I'll commit it in git for now for future reference, and start reworking the generation scripts.

I have plans to build a new service to serve those app icons from a single endpoint - this would let us prefetch a lot of them, but also log missing app icons so we can focus on improving coverage. My thinking is we should have the mapping done based on the package id + package manager, starting with WinGet.

For the short term, once I'm done importing the excel spreadsheet in git with an initial re-generated JSON file, I'll see if I can quickly add a few reported missing app icons. We should probably drop the original .xlsx file in favor of something that is easier to edit and track in git for changes.

[mamoreau-devolutions]

I do have some good news though: as I'm reworking the generation scripts, I noticed that the "Python.Launcher" entry has a trailing newline character, which obviously can't be good. This appears to be a pre-existing issue, so I'll at least work on fixing those encodings errors with the new scripts. Hopefully this will resolve the issue for the Python.Launcher package, as it seems to be fallbacking to "Launcher" instead of picking up the entry for "Python.Launcher"