Scheduler - Appointment Form - Refactor POM#32339
Merged
Tucchhaa merged 4 commits intoDevExpress:26_1from Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Page Object Model (POM) for the Scheduler Appointment Form test infrastructure, improving code quality and maintainability by simplifying interfaces and making them more consistent.
Changes:
- Refactored POM classes to use property getters instead of method calls (e.g.,
getSaveButton()→saveButton) - Renamed
formtodxFormfor better clarity about the DevExtreme Form instance - Removed numerous unused helper methods from both TestCafe and Jest POMs, simplifying the codebase
- Updated all test files to use the new simplified POM interface
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/testcafe-models/scheduler/appointment/popup.ts |
Removed unused selectors and methods; renamed openRecurrenceForm to selectRepeatValue and openRecurrenceSettings to clickRecurrenceSettingsButton; renamed listOption to listItem |
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts |
Major refactoring: added queryRequiredElement helper; converted method-based getters to property getters for buttons and elements; renamed form to dxForm; removed many unused utility methods |
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts |
Updated ~100+ test usages to use new POM interface (.form → .dxForm, method calls → property accesses); removed some await nextTick statements |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/recurrence-form.visual.ts |
Updated method calls to use new POM method names |
e2e/testcafe-devextreme/tests/scheduler/common/appointmentForm/form.functional.ts |
Updated method calls to use new POM method names |
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/model/popup.ts
Show resolved
Hide resolved
aleksei-semikozov
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.