Feat/migrate devextreme to nx part 2#32200
Merged
chaosmirage merged 15 commits intoDevExpress:26_1from Feb 3, 2026
Merged
Conversation
0c4f0e9 to
de4bf99
Compare
de4bf99 to
1de99ac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the Nx migration for DevExtreme by removing the dev mode flag from build scripts, introducing new build workflow orchestration through a dedicated workflows package, and migrating the localization build process to a new Nx executor. The changes simplify the build system by eliminating conditional dev/prod logic in favor of distinct Nx targets and configurations.
Changes:
- Removed dev mode flag from
build-all.tsscript, always running full production builds - Created new
workflowspackage withall:build-devandall:build-testingtargets for build orchestration - Migrated localization generation from Gulp tasks to a new Nx executor with comprehensive E2E tests
- Enhanced
copy-filesandadd-license-headersexecutors with glob pattern and custom template support - Updated CI workflows to use Nx configurations instead of environment variables
- Changed executor logging from
logger.infotologger.verbosefor cleaner output
Reviewed changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Removed yargs dependency and dev mode conditional logic, always runs production build steps |
| package.json | Changed all:build-dev to use new workflows target instead of passing --dev flag |
| packages/workflows/project.json | New package defining all:build-dev and all:build-testing workflow targets |
| packages/nx-infra-plugin/src/executors/localization/* | New localization executor replacing Gulp tasks with E2E tests |
| packages/nx-infra-plugin/src/executors/copy-files/* | Enhanced with glob pattern support and additional tests |
| packages/nx-infra-plugin/src/executors/add-license-headers/* | Enhanced with custom template support and refactored tests |
| packages/nx-infra-plugin/src/executors/*/executor.ts | Changed logging from logger.info to logger.verbose for cleaner console output |
| packages/nx-infra-plugin/package.json | Added lodash and @types/lodash dependencies, changed fs-extra to exact version |
| packages/devextreme/project.json | Added granular build targets, removed npm script-based build, added testing configuration |
| packages/devextreme/package.json | Removed build script (now handled by Nx target) |
| packages/devextreme/build/gulp/localization.js | Replaced complex Gulp tasks with shell command calling Nx executor |
| packages/devextreme-angular/project.json | Added testing configuration and updated dependsOn with params forwarding |
| .github/workflows/*.yml | Updated to use all:build-testing workflow and testing configurations |
| pnpm-lock.yaml | Various minor dependency version updates |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
1de99ac to
ff5e0d5
Compare
bba5b73 to
a346a1c
Compare
4cd260f to
a36fdab
Compare
93ebde5 to
8d2118e
Compare
8d2118e to
9ef4f53
Compare
9ef4f53 to
bad76be
Compare
alexslavr
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be completed after #32047.