fix: remove github_follow token when disconnecting github account#529
fix: remove github_follow token when disconnecting github account#529anirudhagarwal-dev wants to merge 2 commits into
Conversation
|
@anirudhagarwal-dev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — Checks FailedBackend — FAIL
Mobile — SKIP
Web — FAIL
Last updated: |
|
No changes from this PR is required in web module, as we have clearly mentioned that will not have any plan for web based functionalities and the fix added here is not related to web. @Harxhit you can review for backend if that seems relavent to BE. |
Summary
This PR resolves a bug where the
github_followOAuth token remained in the database even after a user disconnected their GitHub account. This was caused by the disconnect endpoint not recognizinggithub_followas a supported platform and only targeting the primarygithubtoken.Closes #458
Type of Change
What Changed
DELETE /api/connect/:platformroute in connect.ts to includegithub_followin the supported platforms list.github, the system now usesdeleteManyto remove both thegithub(login) andgithub_follow(follow-capable) tokens in a single operation.How to Verify
npm --prefix apps/backend run test src/__tests__/connect.test.ts