Skip to content

fix(backend): automatically handle default card reassignment on card deletion #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Harxhit merged 8 commits into from
May 23, 2026
Merged

fix(backend): automatically handle default card reassignment on card deletion #285

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aab05e0
fix(backend): automatically handle default card reassignment on card …
mramansayyad May 23, 2026
3819b03
feat(backend): add limit to card list query
mramansayyad May 23, 2026
bde923a
refactor(backend): add try-catch and typed responses per review
mramansayyad May 23, 2026
27f24d5
Merge branch 'main' into fix-card-deletion
mramansayyad May 23, 2026
3b77203
feat(backend): add Fastify request schemas for card routes
mramansayyad May 23, 2026
5f3ddd1
Merge remote-tracking branch 'origin/main' into fix-card-deletion
mramansayyad May 23, 2026
28ea415
feat(backend): use Fastify typed request schema generics for card routes
mramansayyad May 23, 2026
3abfe08
feat(backend): remove manual JSON request schemas, keeping Fastify ge…
mramansayyad May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions apps/backend/src/routes/cards.ts
View file
Open in desktop

@Harxhit Harxhit May 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap the query inside the try catch for better error handling.

Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,20 @@ import type { Card } from '@devcard/shared';
import { createCardSchema, updateCardSchema } from '../utils/validators.js';
import { handleDbError } from '../utils/error.util.js';

interface CreateCardBody {
title: string;
linkIds: string[];
}

interface UpdateCardBody {
title?: string;
linkIds?: string[];
}

interface CardParams {
id: string;
}

export async function cardRoutes(app: FastifyInstance): Promise<void> {
app.addHook('preHandler', app.authenticate);

Expand Down Expand Up @@ -38,7 +52,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {

// ─── Create Card ───

app.post('/', async (request: FastifyRequest, reply: FastifyReply): Promise<Card | void> => {
app.post('/', async (request: FastifyRequest<{ Body: CreateCardBody }>, reply: FastifyReply): Promise<Card | void> => {
const userId = (request.user as { id: string }).id;
const parsed = createCardSchema.safeParse(request.body);

Expand Down Expand Up @@ -82,7 +96,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {

// ─── Update Card ───

app.put('/:id', async (request: FastifyRequest<{ Params: { id: string } }>, reply: FastifyReply): Promise<Card | void> => {
app.put('/:id', async (request: FastifyRequest<{ Params: CardParams; Body: UpdateCardBody }>, reply: FastifyReply): Promise<Card | void> => {
const userId = (request.user as { id: string }).id;
const { id } = request.params;

Expand Down Expand Up @@ -157,7 +171,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {

// ─── Delete Card ───

app.delete('/:id', async (request: FastifyRequest<{ Params: { id: string } }>, reply: FastifyReply): Promise<void> => {
app.delete('/:id', async (request: FastifyRequest<{ Params: CardParams }>, reply: FastifyReply): Promise<void> => {
const userId = (request.user as { id: string }).id;
const { id } = request.params;

Expand Down Expand Up @@ -200,7 +214,7 @@ export async function cardRoutes(app: FastifyInstance): Promise<void> {

// ─── Set Default Card ───

app.put('/:id/default', async (request: FastifyRequest<{ Params: { id: string } }>, reply: FastifyReply): Promise<object | void> => {
app.put('/:id/default', async (request: FastifyRequest<{ Params: CardParams }>, reply: FastifyReply): Promise<object | void> => {
const userId = (request.user as { id: string }).id;
const { id } = request.params;

Expand Down