Conversation
…sure impact and mitigation are not null
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
damiencarol
left a comment
There was a problem hiding this comment.
Made a lot of comments, one is blocking (urlparse/hyperlink)
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Damien Carol <damien.carol@gmail.com>
Co-authored-by: Damien Carol <damien.carol@gmail.com>
Co-authored-by: Damien Carol <damien.carol@gmail.com>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
madchap
left a comment
There was a problem hiding this comment.
You can completely remove the test_type.json file changes, it's all dynamic now.
|
@madchap when I remove the test type json I can not find a SecureCodeBox Findings Import Test Type |
|
@JohannesZahn it could means that the autoloading of your parser don't works. something is maybe missing |
Co-authored-by: Damien Carol <damien.carol@gmail.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I am putting this on hold since we are currently experimenting with your new generic json parser |
|
We will probably not need this as we are now using the new generic JSON parser. So I will close the PR for now. |
Implemented a secureCodeBox Findings Import.
It is used in a secureCodeBox Hook to automatically import scans into DefectDojo (for scans that have no dedicated parser yet).
The Findings format is described here
See this issue for more information.