Skip to content

fix(content): allow defining inner content without any wrapping html tags, with the ordering kept as written in hiccup#8

Merged
DavidVujic merged 4 commits intomainfrom
element-ordering-with-content
Dec 15, 2024
Merged

fix(content): allow defining inner content without any wrapping html tags, with the ordering kept as written in hiccup#8
DavidVujic merged 4 commits intomainfrom
element-ordering-with-content

Conversation

@DavidVujic
Copy link
Copy Markdown
Owner

@DavidVujic DavidVujic commented Nov 24, 2024

Description

Allow adding content (i.e. inner text) to HTML elements, without having to wrap it within a HTML tag.

Example:

["div", "hello world", ["ul", ["li", "one"], ["li", "two"]]]

Motivation and Context

fixes #7

How Has This Been Tested?

✅ CI
✅ unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

…tags, with the ordering kept as written in hiccup
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@DavidVujic DavidVujic marked this pull request as ready for review December 15, 2024 15:46
@DavidVujic DavidVujic changed the title test: assert that items of different types are ordered as expected fix(content): allow defining inner content without any wrapping html tags, with the ordering kept as written in hiccup Dec 15, 2024
@sonarqubecloud
Copy link
Copy Markdown

@DavidVujic DavidVujic merged commit 0591649 into main Dec 15, 2024
@DavidVujic DavidVujic deleted the element-ordering-with-content branch December 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content (inner text) should be placed in the correct order

2 participants