Skip to content

Add trace filter tests [APMSP-2763]#6952

Draft
Eldolfin wants to merge 2 commits into
mainfrom
oscarld/add-trace-filter-test
Draft

Add trace filter tests [APMSP-2763]#6952
Eldolfin wants to merge 2 commits into
mainfrom
oscarld/add-trace-filter-test

Conversation

@Eldolfin

@Eldolfin Eldolfin commented May 15, 2026

Copy link
Copy Markdown
Contributor

APMSP-2763
APMSP-3048

Motivation

Changes

Add system-tests coverage for the CSS V1.2 spec trace filters (filter_tags, filter_tags_regex, ignore_resources).

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/stats/test_trace_filters.py                                       @DataDog/system-tests-core
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/endtoend.py                                   @DataDog/system-tests-core
utils/_context/containers.py                                            @DataDog/system-tests-core
utils/proxy/mocked_response.py                                          @DataDog/system-tests-core

@Eldolfin Eldolfin changed the title feat: add trace filter tests (checked on stats) feat: add trace filter tests [APMSP-2763] May 15, 2026
@Eldolfin Eldolfin changed the title feat: add trace filter tests [APMSP-2763] Add trace filter tests [APMSP-2763] May 15, 2026
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/libdatadog that referenced this pull request May 19, 2026
… scheme (#2008)

These fields were renamed in version 7.79.0 of the agent for consistency.

# What does this PR do?

Allow both PascalCase and the newer snake_case format for these fields.

# Motivation

The trace exporter was crashing in a confusing way in new system tests I wrote for another feature: DataDog/system-tests#6952. I had an older agent.

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


Co-authored-by: oscar.ledauphin <oscar.ledauphin@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant