feat(otlp-metrics): added support for histogram, exp. histogram, and summary#1853
feat(otlp-metrics): added support for histogram, exp. histogram, and summary#1853
Conversation
…m, and summary metrics
…existing conventions
512959a to
5bc3dc5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37bf8c92cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…on of summary metrics
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0421e01c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5b1c795ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| self.data_points_per_resource = total_data_points(&tpl); | ||
| self.last_collection_time_unix_nano = current_time_unix_nano; |
There was a problem hiding this comment.
This updates the generator-wide last_collection_time_unix_nano inside generate, but to_bytes can still discard the returned ResourceMetrics when request framing pushes it over max_bytes (the pop-and-break path). That means a collection tick is recorded even though nothing was emitted, so newly created delta series can get start_time_unix_nano anchored to an unseen collection interval. Defer this assignment until the resource is actually retained in the request.
Useful? React with 👍 / 👎.
…m, and summary metrics
What does this PR do?
Adds support for the remaining OTLP metrics (Exponential Histogram, Histogram, and Summary) in the correctness tests
Motivation
Will be used to test whether these metric types are being properly handled by ADP in the Saluki repo.
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?