Define dataflows for Datadog-owned integrations (batch 1) - #3093
Draft
philjlee wants to merge 3 commits into
Draft
Define dataflows for Datadog-owned integrations (batch 1)#3093philjlee wants to merge 3 commits into
philjlee wants to merge 3 commits into
Conversation
Each of these integrations ships a metadata.csv with at least one metric row and no log pipeline, so `metrics` is the only data type they provide. Dataflow IDs are `<app_id>-metrics`, matching the convention of the 14 dataflows files already in the repo. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Each of these integrations ships a log pipeline under assets/logs/ and no metrics, so `logs` is the only data type they provide. Dataflow IDs are `<app_id>-logs`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Each of these integrations ships both a metadata.csv with metric rows and a log pipeline under assets/logs/, so each declares two dataflows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 4, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TXP-277
Adds
assets/dataflows.yamlto 74 integrations, declaring 84 dataflows. Mechanical change: no code, no metrics, no manifests touched.Coverage goes from 14/260 (5.4%) to 88/260 (33.8%).
Precedent: #2925 "Define dataflows for saas-integrations", which created 13 of the 14 existing files in this repo.
Selection criteria
A directory is in this batch only if all of the following hold:
assets/dataflows.yamltoday. (14 already do; untouched.)manifest.json. The dataflows validator hard-requires one —dataflows_validation_handler.go:56. 5 directories in this repo lack one and cannot carry the asset at all.data_typeis mechanically derivable from a committed artifact, with no judgement call:metadata.csvwith at least one data row →metricsassets/logs/*.yaml→logs.github/CODEOWNERSresolves<dir>/assets/dataflows.yaml(last-match-wins) to an owner set containing at least one@DataDog/…team.Every directory in this batch has a Datadog team CODEOWNER, so no external maintainer approval is required to merge. The teams involved are
@DataDog/ecosystems-review,@DataDog/agent-integrations,@DataDog/container-integrations, and@DataDog/saas-integrations. External co-owners are auto-requested on many of these paths, but their approval is not a gate.Field values
always_on: true/granular: false/direction: inboundmatches 14 of the 17 dataflow entries already in the repo. The only deviation in the repo isvercel, which isalways_on: falsefor a Serverless product-enablement reason that does not apply here.Dataflow IDs are
<app_id>-<data_type>, takingapp_idfrommanifest.jsonrather than the directory name. This is what all 17 existing entries do — e.g.logzio/→logz-io-events,zscaler/→z-scaler-logs,cockroachdb_dedicated/→cockroach-cloud-metrics. All 84 new IDs were checked for collisions against every existing ID in the repo, and against each other.Validation
These files were validated by executing the real validator,
DataflowsValidationHandlerfromdd-source/domains/integrationscatalog/libs/catalogassetslib/dataflows_validation_handler.go, atddoghq/dd-source@main, against all 88dataflows.yamlfiles in the repo working tree.Result: 88 files, 101 dataflow IDs, 0 failures, covering per-file unmarshalling, proto constraint validation, and the cross-file
HandleLibraryID-uniqueness check.The harness was negative-tested first and confirmed to reject: a missing
always_on; adata_typeoutsidevalidDataTypes; anidbreaking^[a-z0-9-]+$; anidunder 3 characters; a file with neitherprovidesnoruses; a.ymlextension; a missingmanifest.json; and the same dataflow ID provided by two apps.This matters because APW does not post validator comments on integrations-extras PRs (
enable_validator_commentsis set only forpub-platform-stagingandpublishing-platform). A malformeddataflows.yamlmerges cleanly here and only fails afterwards, in the shared asset pipeline.Deferred, and why
rumvalue invalidDataTypes, and no defensible substitute. Needs a schema decision.cfssl,cybersixgill_actionable_alerts,go_pprof_scraper,isdown,reboot_required. Service checks map to nodata_type.data_typeneeds a README read per integration, plus a ruling on whether outbound tiles areevents+direction: outboundat all.#ecosystems-reviewfirst.manifest.jsonaerospike_enterprise,scamalytics,warpstream, plusfluxcdandtraefik, which are README-only and already in APW'sdisabled_collections.No
data_typewas guessed anywhere. Any integration whose correct value was not unambiguous is deferred rather than approximated.Contents
Metrics only (51)
1eone-e-metricsablyably-metricsagora_analyticsagora-analytics-metricsakeyless_gatewayakeyless-gateway-metricsalgorithmiaalgorithmia-metricsauthzed_cloudauthzed-cloud-metricsbuoyant_cloudbuoyant-cloud-metricscensuscensus-metricscloudsmithcloudsmith-metricsconcourse_ciconcourse-ci-metricscribl_streamcribl-stream-metricscyralcyral-metricsembrace_mobileembrace-mobile-metricsemqxemqx-metricsfiddlerfiddler-metricsgatling_enterprisegatling-enterprise-metricshasura_cloudhasura-cloud-metricsinngestinngest-metricslighthouselighthouse-metricsmendixmendix-metricsn2wsn2ws-metricsneo4jneo4j-metricsneoloadneoload-metricsnn_sdwannn-sdwan-metricsns1ns1-metricsoceanbasecloudoceanbase-cloud-metricspacketfabricpacketfabric-metricsperfectscaleperfectscale-metricspostmanpostman-metricspurefapurefa-metricspurefbpurefb-metricsredis_sentinelredis-sentinel-metricsredisenterpriseredisenterprise-metricsscalrscalr-metricsscaphandrescaphandre-metricssinglestoredb_cloudsinglestoredb-cloud-metricssofy_sofysofy-metricssosiviososivio-metricsstarburst_galaxystarburst-galaxy-metricsstatsigstatsig-metricsstormforgestormforge-metricssuperwisesuperwise-metricstidbtidb-metricstidb_cloudtidb-cloud-metricsunitqunitq-metricsupbound_uxpupbound-uxp-metricsupstashupstash-metricsvns3vns3-metricsyugabytedb_managedyugabytedb-managed-metricszebriumzebrium-metricszilliz_cloud_zilliz_cloudzilliz-cloud-zilliz-cloud-metricsLogs only (13)
appomniappomni-logscontrast_security_adrcontrast-security-adr-logsdagsterdagster-plus-logsdopplerdoppler-logsfaunafauna-logsinvaryinvary-logsjfrog_platform_cloudjfrog-platform-cloud-logslaceworklacework-logslambdatestlambdatest-logsngrokngrok-logssqreensqreen-logstwingatetwingate-logstypingdna_activelocktypingdna-activelock-logsMetrics and logs (10)
aimonaimon-metrics,aimon-logsanecdoteanecdote-metrics,anecdote-logsaquaaqua-metrics,aqua-logsauth0auth0-metrics,auth0-logsbind9bind9-metrics,bind9-logsbottomline_recordandreplaybottomline-recordandreplay-metrics,bottomline-recordandreplay-logscelerdatacelerdata-metrics,celerdata-logsgraviteegravitee-metrics,gravitee-logsjfrog_platform_self_hostedjfrog-platform-metrics,jfrog-platform-logswatchtower_zirisziris-metrics,ziris-logs🤖 Generated with Claude Code
CI status — the red checks are pre-existing, not from this PR
validate-dataflows(APW)dataflowsassets are valid." This is the check that matters for this PR.run / Validateddev validate config/ddev validate modelsdrift in 11 integrations.validate-assets,validate-docs_gitlabdocs_gitlab. This is not a problem with your assets."review-checkpurefaandtidb_cloudare excluded because other in-flight PRs touch them.On
run / Validate: this PR adds onlyassets/dataflows.yamlfiles and touches noconf.yaml.example,spec.yaml, or pydantic model. Extras CI validates only changed integrations, so adding a file to these directories pulled them into scope and surfaced drift that was already there.Evidence: the
Validate repositoryworkflow has failed on every one of the last 10 runs onmaster, including9c197fe— this PR's base commit. That master run flags 39 integrations, and the 11 flagged here are a strict subset of those 39:celerdata,emqx,fiddler,jfrog_platform_self_hosted,neo4j,nn_sdwan,purefa,purefb,scalr,scaphandre,upbound_uxpFixing that drift is a separate change with a different blast radius and different reviewers, so it is deliberately not bundled here.