Skip to content

RUM-13454: Reverting deprecated classes back to preserve backward compatibility#3215

Open
satween wants to merge 2 commits intorelease/3.7.0from
tvaleev/feature/RUM-14857
Open

RUM-13454: Reverting deprecated classes back to preserve backward compatibility#3215
satween wants to merge 2 commits intorelease/3.7.0from
tvaleev/feature/RUM-14857

Conversation

@satween
Copy link
Contributor

@satween satween commented Mar 3, 2026

What does this PR do?

  1. Reverting some classes back in order of potential backward compatibility breaking changes
  2. Fixes potential issue with buildResourceId method in case if customer will use different versions for okhttp and rum modules.
  3. Fixes one flaky test with HTTP code 408 which lead to produce different behavior between okHttp and Cronet instrumentation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween satween requested review from a team as code owners March 3, 2026 17:52
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c758ae64ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-official

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 31.11111% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.34%. Comparing base (c217ee7) to head (bbe2a2a).

Files with missing lines Patch % Lines
...id/okhttp/internal/utils/SpanSamplingIdProvider.kt 0.00% 7 Missing ⚠️
...datadog/android/okhttp/trace/TracingInterceptor.kt 33.33% 5 Missing and 1 partial ⚠️
...tadog/android/okhttp/internal/OkHttpRequestInfo.kt 68.75% 3 Missing and 2 partials ⚠️
.../android/okhttp/trace/DeterministicTraceSampler.kt 0.00% 5 Missing ⚠️
.../kotlin/com/datadog/android/okhttp/TraceContext.kt 0.00% 4 Missing ⚠️
...a/com/datadog/android/internal/network/HttpSpec.kt 0.00% 2 Missing ⚠️
...om/datadog/android/okhttp/TraceContextInjection.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/3.7.0    #3215      +/-   ##
=================================================
- Coverage          71.43%   71.34%   -0.09%     
=================================================
  Files                933      937       +4     
  Lines              34596    34632      +36     
  Branches            5850     5861      +11     
=================================================
- Hits               24711    24707       -4     
- Misses              8245     8280      +35     
- Partials            1640     1645       +5     
Files with missing lines Coverage Δ
...a/com/datadog/android/internal/network/HttpSpec.kt 86.36% <0.00%> (-2.01%) ⬇️
...om/datadog/android/okhttp/TraceContextInjection.kt 0.00% <0.00%> (ø)
.../kotlin/com/datadog/android/okhttp/TraceContext.kt 0.00% <0.00%> (ø)
...tadog/android/okhttp/internal/OkHttpRequestInfo.kt 81.08% <68.75%> (-10.59%) ⬇️
.../android/okhttp/trace/DeterministicTraceSampler.kt 0.00% <0.00%> (ø)
...datadog/android/okhttp/trace/TracingInterceptor.kt 82.04% <33.33%> (-1.34%) ⬇️
...id/okhttp/internal/utils/SpanSamplingIdProvider.kt 0.00% <0.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween satween force-pushed the tvaleev/feature/RUM-14857 branch from c758ae6 to 2ff36db Compare March 4, 2026 13:39
@satween satween requested a review from 0xnm March 4, 2026 13:44
@satween
Copy link
Contributor Author

satween commented Mar 4, 2026

@chatgpt-codex-connector review
@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ff36dbde2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants