Skip to content

Improve InsightsCollector.kt methods signatures#3207

Merged
kikoveiga merged 1 commit intodevelopfrom
kikoveiga/improve-insights-collector-methods
Feb 27, 2026
Merged

Improve InsightsCollector.kt methods signatures#3207
kikoveiga merged 1 commit intodevelopfrom
kikoveiga/improve-insights-collector-methods

Conversation

@kikoveiga
Copy link
Contributor

@kikoveiga kikoveiga commented Feb 27, 2026

What does this PR do?

Removes unused startedTimestamp parameters from InsightsCollector interface's methods.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga marked this pull request as ready for review February 27, 2026 15:15
@kikoveiga kikoveiga requested review from a team as code owners February 27, 2026 15:15
0xnm
0xnm previously approved these changes Feb 27, 2026
@kikoveiga kikoveiga force-pushed the kikoveiga/improve-insights-collector-methods branch from cdebd6b to 6f6faa3 Compare February 27, 2026 15:29
@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.43%. Comparing base (8a78565) to head (6f6faa3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3207   +/-   ##
========================================
  Coverage    71.42%   71.43%           
========================================
  Files          933      933           
  Lines        34580    34580           
  Branches      5847     5847           
========================================
+ Hits         24698    24699    +1     
+ Misses        8249     8240    -9     
- Partials      1633     1641    +8     
Files with missing lines Coverage Δ
...roid/insights/internal/DefaultInsightsCollector.kt 76.71% <100.00%> (ø)
...roid/rum/internal/domain/scope/RumResourceScope.kt 90.93% <100.00%> (-0.57%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 93.89% <100.00%> (-0.52%) ⬇️
...m/internal/metric/slowframes/SlowFramesListener.kt 94.64% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga merged commit 2f3dca2 into develop Feb 27, 2026
26 checks passed
@kikoveiga kikoveiga deleted the kikoveiga/improve-insights-collector-methods branch February 27, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants