RUM-13564 Add GraphQL errors support for cross-platform SDKs#3201
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intodevelopfrom Mar 2, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
cdn34dd
previously approved these changes
Feb 27, 2026
0xnm
requested changes
Feb 27, 2026
...ndroid-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
Outdated
Show resolved
Hide resolved
...ndroid-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
Outdated
Show resolved
Hide resolved
...ndroid-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
Outdated
Show resolved
Hide resolved
...id-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScopeTest.kt
Outdated
Show resolved
Hide resolved
...id-rum/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScopeTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikita Ogorodnikov <4046447+0xnm@users.noreply.github.com>
0xnm
previously approved these changes
Feb 27, 2026
Comment on lines
+3523
to
+3533
| val graphql = firstValue.resource.graphql | ||
| checkNotNull(graphql) | ||
| assertThat(graphql.errorCount).isEqualTo(1L) | ||
| assertThat(graphql.errors).hasSize(1) | ||
| val error = checkNotNull(graphql.errors?.first()) | ||
| assertThat(error.message).isEqualTo("field not found") | ||
| assertThat(error.code).isEqualTo("VALIDATION_ERROR") | ||
| assertThat(error.locations).hasSize(1) | ||
| assertThat(error.line).isEqualTo(2L) | ||
| assertThat(error.column).isEqualTo(3L) | ||
| assertThat(error.path).hasSize(2) |
Member
There was a problem hiding this comment.
can you please update all the tests below with a similar change? they are still relying heavily on !!
ambushwork
reviewed
Feb 27, 2026
...ndroid-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumResourceScope.kt
Show resolved
Hide resolved
0xnm
previously approved these changes
Feb 27, 2026
Comment on lines
+3602
to
+3603
| assertThat(graphql).isNotNull | ||
| assertThat(graphql!!.errorCount).isNull() |
Member
There was a problem hiding this comment.
nit: seems like here and in the tests below there is still !!
cdn34dd
previously approved these changes
Mar 2, 2026
0xnm
previously approved these changes
Mar 2, 2026
ambushwork
previously approved these changes
Mar 2, 2026
3e53482 to
acb07a4
Compare
0xnm
approved these changes
Mar 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3201 +/- ##
===========================================
- Coverage 71.46% 71.36% -0.10%
===========================================
Files 928 928
Lines 34444 34460 +16
Branches 5812 5815 +3
===========================================
- Hits 24613 24589 -24
- Misses 8224 8238 +14
- Partials 1607 1633 +26
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
This PR adds support for the
_dd.graphql.errorsattribute on Android so that cross-platform SDKs (React Native, Flutter) can report GraphQL errors on both platforms.