Revert "RUM-6171 use FileObserver to limit calls to filesystem"#3124
Merged
aleksandr-gringauz merged 1 commit intodevelopfrom Jan 13, 2026
Merged
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: bade6c9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3124 +/- ##
===========================================
- Coverage 70.78% 70.74% -0.04%
===========================================
Files 893 893
Lines 33014 33000 -14
Branches 5554 5549 -5
===========================================
- Hits 23366 23343 -23
+ Misses 8107 8101 -6
- Partials 1541 1556 +15
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Jan 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUM integration tests in
instrumented/integrationstarted failing with the following stacktrace:It can be reproduced locally if you run all the tests in rum folder.
This is most likely caused by #2720. I suggest reverting it and think about the proper fix later in future PRs.
I added some logging to better understand the problem https://github.com/DataDog/dd-sdk-android/tree/aleksandr-gringauz/file-observer-concurrency
The following happens:
DatadogUploadRunnableconsumes the batch, sends it and confirms that it read it here.knownFilesinBatchFileOrchestratorisn't immediately updated, becauseFileObserverworks asynchronously.DatadogUploadRunnablereads next batch. It tries to read the same batch file as before, because the state inBatchFileOrchestratorisn't updated yet. We end up here.DatadogUploadRunnablesends the request body with an empty batch. It leads to the exception in the test.