Skip to content

durable: extract trace context from checkpoints and input payload#818

Open
joeyzhao2018 wants to merge 1 commit intomainfrom
joey/durable-tracecontext-extraction
Open

durable: extract trace context from checkpoints and input payload#818
joeyzhao2018 wants to merge 1 commit intomainfrom
joey/durable-tracecontext-extraction

Conversation

@joeyzhao2018
Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20b00544e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread datadog_lambda/tracing.py
if not isinstance(event, dict):
return []

operations = event.get("InitialExecutionState", {}).get("Operations")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard non-dict InitialExecutionState before reading Operations

_durable_operations assumes event["InitialExecutionState"] is a dict and immediately chains .get("Operations"); if that field is null or any non-dict value, this raises AttributeError and aborts durable trace extraction instead of falling back to other context sources. This is a regression path introduced by the new durable extractor and can disable tracing for malformed or partially-populated durable events that still include DurableExecutionArn.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant