fix(session): dedupe compaction execution by Dandi007 · Pull Request #3 · Dandi007/opencode

Dandi007 · 2026-05-16T13:05:24Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

This PR fixes duplicate compaction execution when more than one compaction trigger overlaps in the same session.

Technical spec

Goal. OpenCode should treat compaction as a per-session singleton while a compaction marker is still active. Duplicate manual, automatic, or overflow-triggered compaction requests should merge into the same pending marker instead of creating multiple summary tasks.

Problem scene. In the failing runtime shape, one session can contain several type=compaction user markers created close together, while later prompt-loop execution may attach a assistant(agent=compaction) summary to a newer normal/synthetic user message instead of the marker that requested compaction. That makes the UI and sync clients observe duplicate compactions, orphan compaction markers, and summary assistants with the wrong parentID.

Root cause. There were three related gaps:

SessionCompaction.create() inserted marker message/part rows directly, so overlapping callers could leave more than one active marker and live sync consumers did not receive message.updated / message.part.updated events for the marker.
The prompt loop previously needed to preserve the compaction task owner message id. Without that owner binding, old pending markers could be processed under the latest user message.
SessionCompaction.process() treated an unfinished compaction assistant for the same marker as a permanent "stop". If the process crashed after writing the assistant message but before setting finish or error, future loops kept seeing the same active task but never retried or finalized it.

Fix strategy. This PR enforces these invariants:

active marker dedupe: create() checks and inserts inside one immediate DB transaction, so a session has at most one active compaction marker;
owner-marker binding: compaction processing uses the marker owner id as parentID, not the latest user message;
process idempotency: completed summaries for a marker are reused instead of duplicated;
unfinished recovery: stale unfinished compaction assistants are marked aborted and the same marker is retried;
live sync visibility: newly created marker message/part rows are also published through the standard session.updateMessage / session.updatePart sync event path.

This fixes the bug because duplicate compaction requests become mergeable events rather than queued work. The marker remains the durable owner of the compaction task, so prompt-loop retries cannot accidentally bind a summary to a later user message. Publishing through the normal sync event path also keeps CLI/share/remote clients in sync without waiting for a SQLite reload.

How did you verify your code works?

Ran locally from packages/opencode:

bun test --timeout 30000 ./test/session/compaction.test.ts ./test/session/prompt.test.ts
bun test --timeout 60000 ./test/session/compaction-runtime-e2e.test.ts
bun test --timeout 30000 ./test/session/session.test.ts
bun typecheck

Results:

113 pass, 0 fail across compaction.test.ts and prompt.test.ts
1 pass, 0 fail for compaction-runtime-e2e.test.ts
4 pass, 0 fail for session.test.ts
bun typecheck completed successfully

Screenshots / recordings

Not applicable; this is session runtime behavior with automated test coverage.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Dandi007 · 2026-05-16T13:09:46Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc39bc60a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-16T13:13:28Z

+            tx.insert(MessageTable).values({ id, session_id: sessionID, time_created: now, data: info }).run()
+            tx.insert(PartTable)
+              .values({ id: partID, message_id: messageID, session_id: partSessionID, time_created: now, data: partData })
+              .run()


Publish compaction marker through sync events

This direct insert bypasses session.updateMessage/session.updatePart, which are the only paths here that call sync.run(MessageV2.Event.Updated/PartUpdated). When a compaction marker is created, sync consumers such as CLI/share watchers and remote clients that learn messages from those events will not receive or replay the new user message/part until they reload from SQLite, so the pending compaction can be invisible in live sessions.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-16T13:13:29Z

+          msg.info.parentID === input.parentID &&
+          !msg.info.error,
+      )
+      if (existing?.info.role === "assistant") return existing.info.finish ? "continue" : "stop"


Retry unfinished compaction assistants

If the process is interrupted or crashes after the compaction assistant message is written but before processor.process records a finish/error, this new dedupe branch returns "stop" forever for that marker. The prompt loop will keep seeing the same active compaction task, but process never retries it or marks it failed, leaving the session unable to finish compaction without manual cleanup.

Useful? React with 👍 / 👎.

github-actions · 2026-05-16T13:42:46Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions · 2026-05-16T13:44:35Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Dandi007 · 2026-05-16T14:23:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed6b00ef80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-16T14:29:12Z

+        Database.transaction(
+          (tx) => {
+            const messages = Array.from(MessageV2.stream(input.sessionID)).reverse()
+            if (activeCompactionMarker(messages)) return undefined


Skip stale compaction markers when deduping

If a session already contains an unfinished compaction marker that is older than the latest finished assistant (for example from a crash or from the previous duplicate-compaction behavior), MessageV2.latest() in prompt.ts will no longer surface that marker as a task because it drops task parts on messages at or before the latest finished assistant. This new check still treats that old marker as active and returns before creating a fresh marker, so future auto or manual compaction for that session can be permanently blocked. Consider limiting the dedupe check to markers that are actually pending for the current prompt loop, or otherwise ignoring/closing markers that are older than the latest finished assistant.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-16T14:29:12Z

+    OPENCODE_CONFIG_CONTENT: JSON.stringify(providerConfig(baseURL)),
+    PATH: `${path.dirname(BUN_BIN)}:${process.env.PATH ?? ""}`,
+  }
+  const proc = Bun.spawn([BUN_BIN, "run", "--conditions=browser", "./src/index.ts", "serve", "--port", "0", "--hostname", "127.0.0.1"], {


Use the current Bun executable in the e2e test

In CI or developer environments where Bun is installed by a package manager, asdf/mise, Nix, or another non-default location, ~/.bun/bin/bun may not exist even though the test runner is Bun. This Bun.spawn then fails before the server can start, making the new e2e test environment-dependent; use process.execPath (as other tests in this repo do) or resolve bun from PATH instead of the hard-coded home path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-16T14:29:12Z

+      )
+      let inputMessages = input.messages
+      if (existing?.info.role === "assistant") {
+        if (existing.info.finish) return "continue"


Finish marker bookkeeping before returning existing summaries

When a compaction retry sees a finished summary but the previous run crashed after the assistant was finalized and before the marker bookkeeping below ran, this early return prevents the retry from setting tail_start_id or creating the auto-continue follow-up. In that recovery window the compacted session can drop the preserved tail from future context, and automatic compaction can stop without resuming the user's request; handle the already-finished case by completing the missing marker/follow-up work before returning.

Useful? React with 👍 / 👎.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Dandi007 and others added 8 commits May 16, 2026 16:21

fix(session): dedupe active compaction markers

90e627d

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

fix(session): track compaction task owners

8b423b2

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

fix(session): bind compaction processing to marker owner

44ed114

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

test(session): cover compact trigger idempotency

9862059

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

test(session): add runtime compaction e2e

b0891fc

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

fix(session): allow new compaction after errored one

a96b544

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

fix(session): adapt compact dedupe to dev

29db465

Merge branch 'qinglin-dev' into fix/double-compact-execution-dev

fc39bc6

github-actions Bot added the needs:compliance label May 16, 2026

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Dandi007 changed the title ~~feat: fix multiple compact~~ fix(session): dedupe compaction execution May 16, 2026

github-actions Bot added needs:issue and removed needs:compliance labels May 16, 2026

fix(session): recover compaction marker sync

ed6b00e

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Dandi007 and others added 3 commits May 16, 2026 23:21

fix(session): recover stale compaction markers

bba7165

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

test(session): use current bun executable

8269451

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

chore: stamp qinglin dev versions

eb04273

github-actions Bot removed the needs:issue label May 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(session): dedupe compaction execution#3

fix(session): dedupe compaction execution#3
Dandi007 wants to merge 12 commits into
qinglin-devfrom
fix/double-compact-execution-dev

Dandi007 commented May 16, 2026 •

edited

Loading

Uh oh!

Dandi007 commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

Dandi007 commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Dandi007 commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

Technical spec

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

Dandi007 commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

Dandi007 commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Dandi007 commented May 16, 2026 •

edited

Loading