crypto: only include gmp.h on MSVC to disable the warning, add a comment explaining why#1786
Merged
crypto: only include gmp.h on MSVC to disable the warning, add a comment explaining why#1786
Conversation
…ent explaining why
slipher
reviewed
Sep 4, 2025
|
|
||
| #pragma warning(push) | ||
| #pragma warning(disable : 4146) // "unary minus operator applied to unsigned type, result still unsigned" | ||
| #include <gmp.h> |
Member
There was a problem hiding this comment.
The Nettle headers include the GMP header. So this may be here just for the warning fix. You could get rid of the GMP include but the MSVC warning adjustment would still need to be used for the Nettle headers.
Member
Author
There was a problem hiding this comment.
I modified the commit to only include GMP on MSVC for the purpose of disabling the warning, and added a comment explaining why we do that.
a470161 to
6d4808e
Compare
Member
|
LGTM |
6d4808e to
5d14eff
Compare
Member
Author
|
I modified the |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only include gmp.h on MSVC to disable the warning, add a comment explaining why.
Former comment:
Do not include
gmp.h, It is unused.We need to link against GMP because we link against Nettle that requires it, but it looks like ourselves never use any symbol from GMP directly.
Imported from #1433:
When testing #1433 I was able to rebuild every engine binaries and NaCl VMs in Docker with this commit, I also built dll VM locally fine.