removed problematic candidate_window config updates in the trmonrequestor_test#480
Merged
bieryAtFnal merged 1 commit intodevelopfrom Mar 2, 2026
Merged
removed problematic candidate_window config updates in the trmonrequestor_test#480bieryAtFnal merged 1 commit intodevelopfrom
bieryAtFnal merged 1 commit intodevelopfrom
Conversation
eflumerf
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that there seems to have been a copy/paste error introduced into the
trmonrequestor_testrecently.readout_window_time_beforeandreadout_window_time_afterlocal variables are referenced but are not defined in that test.The changes in this PR remove the problematic configuration updates, and remove a possibly left-over print statement.
To test these changes, here are some suggested steps:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)