Skip to content

removed problematic candidate_window config updates in the trmonrequestor_test#480

Merged
bieryAtFnal merged 1 commit intodevelopfrom
kbiery/trmon_test_fix
Mar 2, 2026
Merged

removed problematic candidate_window config updates in the trmonrequestor_test#480
bieryAtFnal merged 1 commit intodevelopfrom
kbiery/trmon_test_fix

Conversation

@bieryAtFnal
Copy link
Collaborator

Description

I noticed that there seems to have been a copy/paste error introduced into the trmonrequestor_test recently. readout_window_time_before and readout_window_time_after local variables are referenced but are not defined in that test.

The changes in this PR remove the problematic configuration updates, and remove a possibly left-over print statement.

To test these changes, here are some suggested steps:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260301_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop
cd daqsystemtest ; git checkout kbiery/colorize_error_in_bundle_script; cd ..
git clone https://github.com/DUNE-DAQ/dfmodules.git -b develop
cd ..

dbt-workarea-env
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r dfmodules -k trmon

echo ""
echo -e "\U1F535 \U2705 Note that the trmon integtest failed. \U2705 \U1F535"
echo ""
echo ""
sleep 3

cd sourcecode/dfmodules
git checkout kbiery/trmon_test_fix
cd ../..

dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r dfmodules -k trmon

echo ""
echo -e "\U1F535 \U2705 Note that the trmon integtest now works. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

@bieryAtFnal bieryAtFnal requested a review from eflumerf March 2, 2026 13:07
@bieryAtFnal bieryAtFnal merged commit 07225b1 into develop Mar 2, 2026
4 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/trmon_test_fix branch March 2, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants