Skip to content

fix: compare incoming value with modal's value#887

Merged
mortalYoung merged 1 commit into
DTStack:mainfrom
jin-sir:fix_updateTab
Jun 18, 2024
Merged

fix: compare incoming value with modal's value#887
mortalYoung merged 1 commit into
DTStack:mainfrom
jin-sir:fix_updateTab

Conversation

@jin-sir

@jin-sir jin-sir commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Description

There exists a infinite loop.Determine whether to update the modal value based on comparing the passed-in value and the modal value.

Fixes # (issue)

#881

@jin-sir
jin-sir marked this pull request as draft June 13, 2024 15:27
@jin-sir
jin-sir marked this pull request as ready for review June 13, 2024 15:29
@jin-sir jin-sir changed the title fix: not set the modal's value in the current tab fix: compare incoming value with modal's value Jun 14, 2024
@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (555abe1) to head (96187df).

Files Patch % Lines
src/services/workbench/editorService.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   90.94%   90.92%   -0.03%     
==========================================
  Files         188      188              
  Lines        6085     6093       +8     
  Branches     1449     1478      +29     
==========================================
+ Hits         5534     5540       +6     
- Misses        546      547       +1     
- Partials        5        6       +1     
Flag Coverage Δ
integration 90.92% <75.00%> (-0.03%) ⬇️
unittests 90.92% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants