fix: initView and load extensions after workbench be ready#853
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 91.06% 91.00% -0.07%
==========================================
Files 188 188
Lines 6078 6080 +2
Branches 1476 1478 +2
==========================================
- Hits 5535 5533 -2
- Misses 537 541 +4
Partials 6 6
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
修复
monacoService无法初始化的问题。由于layout.contaier依赖Workbench对象,所以需要等WorkbenchReady 后,才能初始化monacoService已经相关插件,否则,布局会以document.body作为根容器,这样在嵌入式Workbench布局的中,会出现类似 CommandPalette 位置异常的问题。Fixes #852
Changes