Skip to content

fix: remove contextView warning in console#832

Merged
wewoor merged 3 commits into
mainfrom
fix/contextView
Nov 25, 2022
Merged

fix: remove contextView warning in console#832
wewoor merged 3 commits into
mainfrom
fix/contextView

Conversation

@mortalYoung

Copy link
Copy Markdown
Collaborator

简介

  • 优化 ContextView 的控制台警告

Related Issues

Closed #830

@mortalYoung mortalYoung added the bug Something isn't working label Nov 23, 2022
@mortalYoung
mortalYoung requested a review from wewoor November 23, 2022 07:25
@mortalYoung mortalYoung self-assigned this Nov 23, 2022

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung
mortalYoung requested a review from wewoor November 25, 2022 02:57
@codecov

codecov Bot commented Nov 25, 2022

Copy link
Copy Markdown

Codecov Report

Base: 91.15% // Head: 91.11% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (704e3ac) compared to base (9418d40).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   91.15%   91.11%   -0.04%     
==========================================
  Files         180      180              
  Lines        5797     5805       +8     
  Branches     1408     1410       +2     
==========================================
+ Hits         5284     5289       +5     
- Misses        507      510       +3     
  Partials        6        6              
Impacted Files Coverage Δ
src/components/contextView/index.tsx 100.00% <100.00%> (ø)
src/components/dropdown/index.tsx 100.00% <100.00%> (ø)
src/workbench/activityBar/activityBar.tsx 97.56% <100.00%> (+0.06%) ⬆️
src/workbench/activityBar/activityBarItem.tsx 100.00% <100.00%> (ø)
src/workbench/sidebar/explore/folderTree.tsx 97.70% <100.00%> (ø)
src/workbench/menuBar/horizontalView.tsx 93.75% <0.00%> (-6.25%) ⬇️
src/services/instanceService.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit 2cf87db into main Nov 25, 2022
@wewoor
wewoor deleted the fix/contextView branch November 25, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: warning in console

2 participants