Skip to content

feat: support to set the direction of editor group#822

Merged
wewoor merged 2 commits into
mainfrom
feat/group
Nov 3, 2022
Merged

feat: support to set the direction of editor group#822
wewoor merged 2 commits into
mainfrom
feat/group

Conversation

@mortalYoung

@mortalYoung mortalYoung commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

简介

  • 支持在 layoutService 中改变 editorGroup 的方向

遗留问题

  • 测试用例

@mortalYoung mortalYoung self-assigned this Nov 2, 2022
@mortalYoung
mortalYoung requested a review from wewoor November 2, 2022 11:35
@mortalYoung mortalYoung changed the title feat: support to set the direction of editor group 【WIP】feat: support to set the direction of editor group Nov 2, 2022
@codecov

codecov Bot commented Nov 2, 2022

Copy link
Copy Markdown

Codecov Report

Base: 91.06% // Head: 91.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a15efe5) compared to base (d697d0b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   91.06%   91.07%   +0.01%     
==========================================
  Files         180      180              
  Lines        5795     5802       +7     
  Branches     1405     1408       +3     
==========================================
+ Hits         5277     5284       +7     
  Misses        512      512              
  Partials        6        6              
Impacted Files Coverage Δ
src/model/workbench/layout.ts 100.00% <100.00%> (ø)
src/services/workbench/layoutService.ts 100.00% <100.00%> (ø)
src/workbench/editor/editor.tsx 95.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mortalYoung mortalYoung changed the title 【WIP】feat: support to set the direction of editor group feat: support to set the direction of editor group Nov 3, 2022

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit f0ca348 into main Nov 3, 2022
@wewoor
wewoor deleted the feat/group branch November 3, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants