Skip to content

feat: define loadedKey to be controlled#803

Merged
wewoor merged 3 commits into
mainfrom
fix/loadedkeys
Sep 19, 2022
Merged

feat: define loadedKey to be controlled#803
wewoor merged 3 commits into
mainfrom
fix/loadedkeys

Conversation

@mortalYoung

@mortalYoung mortalYoung commented Sep 16, 2022

Copy link
Copy Markdown
Collaborator

简介

  • 修复 reset 执行后 loadedKeys 的缓存仍然有效的问题

主要变更

新增 loadedKeys 字段,用于对已加载过的 keys 做受控,在删除和重置的时候会去修改该字段的值

Related Issues

#802

@mortalYoung mortalYoung added the bug Something isn't working label Sep 16, 2022
@mortalYoung mortalYoung self-assigned this Sep 16, 2022
@codecov

codecov Bot commented Sep 16, 2022

Copy link
Copy Markdown

Codecov Report

Base: 91.04% // Head: 91.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a93d78e) compared to base (c305470).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   91.04%   91.05%   +0.01%     
==========================================
  Files         180      180              
  Lines        5786     5793       +7     
  Branches     1402     1404       +2     
==========================================
+ Hits         5268     5275       +7     
  Misses        512      512              
  Partials        6        6              
Impacted Files Coverage Δ
src/model/workbench/explorer/folderTree.tsx 92.59% <ø> (ø)
src/workbench/sidebar/explore/folderTree.tsx 97.70% <ø> (ø)
src/components/tree/index.tsx 98.98% <100.00%> (-0.02%) ⬇️
src/controller/explorer/folderTree.tsx 100.00% <100.00%> (ø)
...c/services/workbench/explorer/folderTreeService.ts 99.48% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit 219b937 into main Sep 19, 2022
@wewoor
wewoor deleted the fix/loadedkeys branch September 19, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants